[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27176: [PATCH] gnu: Add python-xsge.
From: |
Kei Kebreau |
Subject: |
bug#27176: [PATCH] gnu: Add python-xsge. |
Date: |
Wed, 31 May 2017 20:50:33 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Danny Milosavljevic <address@hidden> writes:
>> + (replace 'install
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (zero?
>> + (system* "python" "setup.py" "install"
>> + (string-append "--prefix=" (assoc-ref outputs "out"))
>> + "--root=/")))))
>
> What's the difference to what the python-build-system does?
The python-build-system also uses "--single-version-externally-managed"
which is unsupported by xSGE's setup.py script for some reason. I've
added a comment stating this.
>
>> + #:tests? #f))
>
> Why?
>
I forgot the "no check target" comment, but I've since added it.
>> + (description
>> + "xSGE is a collection of modules that make doing certain tasks with
>> the SGE
>> +Game Engine easier.")
>
> Like what? :)
I added details from the list on the xSGE about page.
>
> Otherwise LGTM!
Pushed to master as e99039b5da6dfbc49a2f8cf0fb523a8049fe5ef8!
Thanks for the review.
signature.asc
Description: PGP signature