guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#28201] [PATCH] gnu: Add emacs-wgrep.


From: Christopher Baines
Subject: [bug#28201] [PATCH] gnu: Add emacs-wgrep.
Date: Mon, 28 Aug 2017 11:58:52 +0100

On Wed, 23 Aug 2017 09:51:57 -0400
Kyle Meyer <address@hidden> wrote:

> Christopher Baines <address@hidden> writes:
> 
> > * gnu/packages/emacs.scm (emacs-wgrep): New variable.  
> 
> Thanks, wgrep is very useful.
> 
> >  gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)  
> 
> [...]
> 
> > +    (description
> > +     "Emacs wgrep allows you to edit a grep buffer and apply those
> > changes to +the file buffer.
> > +
> > +Activate by using:
> > +
> > address@hidden
> > +(require 'wgrep)
> > address@hidden example")  
> 
> I'm not sure the description should include information on activating
> the package (especially when it involves fairly standard steps).
> Quickly scanning emacs.scm, I didn't spot any other descriptions that
> have similar instructions.
> 
> Also, "(require 'wgrep)" shouldn't be needed here because Guix sets up
> the autoloads.  Calling wgrep-change-to-wgrep-mode from a grep-mode
> buffer is the common entry point, I think, and wgrep autoloads that
> command.

That makes sense. I've tested the package, and it does indeed work
without running (require 'wgrep). I'll send an updated patch without
this.

Attachment: pgppdAEfbuopb.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]