guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28787: [PATCH 2/2] emacs-build-system: Change how patch-el-files sub


From: Christopher Baines
Subject: bug#28787: [PATCH 2/2] emacs-build-system: Change how patch-el-files substitutes commands.
Date: Sun, 15 Oct 2017 19:09:07 +0100

On Fri, 13 Oct 2017 23:40:55 +0200
address@hidden (Ludovic Courtès) wrote:

> Christopher Baines <address@hidden> skribis:
> 
> > Previously the regex would match from /bin/ to a closing quote. However, 
> > this
> > is greedy, so will match up until the last ". This causes problems when 
> > there
> > are several quotes on the same line, for example:
> >
> > org-effectiveness.el:
> > 196:      (call-process "/bin/bash" nil t nil "-c" strplot)
> >
> > Therefore, change . to \S so that it doesn't include whitespace
> > characters. Changing to a lazy quantifier would be an option, if that were
> > supported.
> >
> > * guix/build/emacs-build-system.scm (patch-el-files): Change the regular
> >   expression used.  
> 
> Good catch, LGTM!

Great :) I've now pushed the updated version of these two patches.

Attachment: pgpSohO6k48pT.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]