[bug#28913] [PATCH 2/2] gnu: Add criu.

[Ricardo Wurmus]

Ludovic Courtès <address@hidden> writes:

> Ricardo Wurmus <address@hidden> skribis:
>
>> * gnu/packages/virtualization.scm (criu): New variable.
>
> [...]
>
>> +         (replace 'configure
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             ;; The includes for libnl are located in a sub-directory.
>> +             (setenv "C_INCLUDE_PATH"
>> +                     (string-append (assoc-ref inputs "libnl")
>> +                                    "/include/libnl3:"
>> +                                    (getenv "C_INCLUDE_PATH")))
>
> And there’s no libnet.pc or similar to provide the right -I flag?

There is a libnl-3.0.pc file with these contents:

--8<---------------cut here---------------start------------->8---
prefix=/gnu/store/qyr5m7c21a4myx5421m90yxkxav2qij7-libnl-3.4.0
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: libnl
Description: Convenience library for netlink sockets
Version: 3.4.0
Libs: -L${libdir} -lnl-3
Cflags: -I${includedir}/libnl3
--8<---------------cut here---------------end--------------->8---

That’s not enough, though, to find header files included by other libnl
headers.  Without the setenv snippet above compilation fails with this
error:

--8<---------------cut here---------------start------------->8---
In file included from criu/libnetlink.c:5:0:
/gnu/store/qyr5m7c21a4myx5421m90yxkxav2qij7-libnl-3.4.0/include/libnl3/netlink/attr.h:15:29:
 fatal error: netlink/netlink.h: No such file or directory
compilation terminated.
--8<---------------cut here---------------end--------------->8---

>> +    (synopsis "Checkpoint and restore in userspace")
>
> “user space” (two words)?

Okay. Thanks for reviewing these patches!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net