guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29030: [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TO


From: Eric Bavier
Subject: bug#29030: [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.
Date: Sat, 28 Oct 2017 18:29:07 -0500

On Sat, 28 Oct 2017 09:51:24 +0200
address@hidden (Ludovic Courtès) wrote:

> Hi Eric,
> 
> Eric Bavier <address@hidden> skribis:
> 
> > On my system, perl-sys-cpu's tests fail because of differences in the 
> > information available in /proc/cpuinfo.
> >
> > Debian's patch for this perl module seemed nice: rather than trying to fix 
> > the related functions, just concede that the module is mostly used just to 
> > read the number of available processors and mark the other tests as "TODO". 
> >  
> 
> [...]
> 
> > +              (snippet
> > +               '(begin
> > +                  ;; Replace test with one that marks cpu_clock and 
> > cpu_type
> > +                  ;; as TODO.  Borrowed from Debian.  
> 
> Perhaps make it clear in the comment that we do this because the
> contents of /proc/cpuinfo differ based on different factors.

OK.

> Otherwise LGTM, thanks!

Thanks, pushed in 9de52b56438674c0d0f92be34cebf5f1a38a6bfa.

`~Eric





reply via email to

[Prev in Thread] Current Thread [Next in Thread]