guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#29130] [PATCH] gnu: networking: Add websockify.


From: Rutger Helling
Subject: [bug#29130] [PATCH] gnu: networking: Add websockify.
Date: Mon, 06 Nov 2017 10:39:09 +0100

Hey Marius,

thanks for the review. Here's an updated patch. Unfortunately two out of six tests fail due to an ImportError.
The module 'stubout' should be imported from python-mox3 but for some reason isn't.
I'll try and find a solution at a later date, but for now I've disabled the tests and added a FIXME.

On 2017-11-05 16:46, Marius Bakke wrote:

Rutger Helling <address@hidden> writes:

Hey Guix,

here's a patch that adds websockify.

Thanks for this!

[...]

+(define-public websockify
+  (package
+    (name "websockify")
+    (version "0.8.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/novnc/websockify/archive/v"
+                                  version "/archive.tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1kjq6gibsvbb6zx5gi8hgh7110x62pbwcqkwapf3k7s27w5y907h"))))
+    (build-system python-build-system)
+    (inputs `(("python-numpy", python-numpy)))

"python-numpy" needs to be a propagated-input, since it is imported by
the installed library.  Otherwise packages using the websockify library
won't be able to find 'numpy'.

+    (home-page "https://github.com/novnc/websockify")

I noticed this package has a '.travis.yml' that runs 'python setup.py
nosetests' for tests -- currently the 'check' phase just prints "Ran 0
tests in 0.00s".  Can you try overriding the check phase with one that
runs the same command?

+    (synopsis "WebSockets support for any application/server")
+    (description "Websockify translates WebSockets traffic to normal socket
+traffic.  Websockify accepts the WebSockets handshake, parses it, and then
+begins forwarding traffic between the client and the target in both
+directions.")
+;; websockify is licensed under the LGPL version 3 with the following
+;; exceptions:
+;; include/websock.js : MPL 2.0
+;; include/base64.js : MPL 2.0
+;; include/des.js : Various BSD style licenses
+;; include/web-socket-js/ : New BSD license (3-clause).
+;; other/kumina.c : Simplified BSD license (2 clause).
+    (license license:lgpl3)))

Indeed version 3 only.

Can you send an updated patch please? :)


Attachment: 0001-gnu-networking-Add-websockify-v2.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]