[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29392] [PATCH 02/11] build-system: Add scons-build-system.
From: |
Leo Famulari |
Subject: |
[bug#29392] [PATCH 02/11] build-system: Add scons-build-system. |
Date: |
Sun, 26 Nov 2017 16:04:12 -0500 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Nov 22, 2017 at 03:04:58PM +0530, Arun Isaac wrote:
> * guix/build-system/scons.scm: New file.
> * guix/build/scons-build-system.scm: New file.
> * Makefile.am (MODULES): Register them.
> * doc/guix.texi (Build Systems): Add scons-build-system.
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -42,6 +42,7 @@ Copyright @copyright{} 2017 Hartmut address@hidden
> Copyright @copyright{} 2017 Maxim address@hidden
> Copyright @copyright{} 2017 Tobias address@hidden
> Copyright @copyright{} 2017 George Clemmer
> +Copyright @copyright{} 2017 Arun Isaac
Make sure to add a line break (@*) after George's name.
https://www.gnu.org/software/texinfo/manual/texinfo/html_node/Line-Breaks.html
> address@hidden {Scheme Variable} scons-build-system
> +This variable is exported by @code{(guix build-system scons)}. It
> +implements the build procedure used by the @code{scons} software
Here we are not referring to SCons itself, but not a code variable. So,
I think we can skip using @code here.
> +construction tool. This build system runs @code{scons} to build the
> +package, @code{scons test} to run tests, and then @code{scons install}
> +to install the package. Additional flags to be passed to @code{scons}
^
Same here ---------------------------------------------------|
> diff --git a/guix/build-system/scons.scm b/guix/build-system/scons.scm
[...]
> +;; Standard build procedure for applications using 'scons'. This is
I would say SCons instead of 'scons', and anywhere we refer to SCons as
a project rather than a particular program. This is mostly in the
manual, comments, docstrings, etc.
> + (build-inputs `(("scons-python2" ,(module-ref (resolve-interface
> '(gnu packages python)) 'scons-python2))
> + ,@native-inputs))
Is there a particular reason we use a Python 2 variant of SCons? If so,
can you explain it in a code comment?
> +(define* (scons-build store name inputs
> + #:key
> + (tests? #t)
> + (scons-flags ''())
> + (test-target "test")
> + (phases '(@ (guix build scons-build-system)
> + %standard-phases))
> + (outputs '("out"))
> + (search-paths '())
> + (system (%current-system))
> + (guile #f)
> + (imported-modules %scons-build-system-modules)
> + (modules '((guix build scons-build-system)
> + (guix build utils))))
> + "Build SOURCE using SCONS, and with INPUTS. This assumes that SOURCE
There isn't a variable named 'scons' here, so I think it would be
SCONS-PYTHON2.
signature.asc
Description: PGP signature
- [bug#29392] [PATCH 00/11] New scons build system, Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 01/11] gnu: scons: Update to 3.0.1., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 04/11] gnu: gpick: Use scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 11/11] gnu: pingus: Use HTTPS for home page., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 05/11] gnu: serf: Use scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 10/11] gnu: mongodb: Use scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 02/11] build-system: Add scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 02/11] build-system: Add scons-build-system.,
Leo Famulari <=
- [bug#29392] [PATCH 06/11] gnu: metabat: Use scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 08/11] gnu: pingus: Use scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 07/11] gnu: godot: Use scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 03/11] gnu: linuxdcpp: Use scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 09/11] gnu: klick: Use scons-build-system., Arun Isaac, 2017/11/22
- [bug#29392] [PATCH 00/11] New scons build system, Leo Famulari, 2017/11/25
- [bug#29392] [PATCH 00/11] New scons build system, Leo Famulari, 2017/11/25
- [bug#29392] [PATCH 00/11] New scons build system, Leo Famulari, 2017/11/25