bug#30003: [PATCH 2/2] gnu: services: Add darkstat service.

[宋文武]

address@hidden (Ludovic Courtès) writes:

> Hello,
>
> 宋文武 <address@hidden> skribis:
>
>> * gnu/services/monitoring.scm: New file.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>> * doc/guix.texi (Monitoring Services): Document it.
>
> Nice!
>
> I only have minor suggestions:
>
>> address@hidden Darkstat Service
>> address@hidden darkstat
>> address@hidden is a packet sniffer that captures network traffic,
>
> I think you can remove @command since you’re referring to the software,
> not to the command.
>
>> address@hidden
>> +(service darkstat-service-type
>> +  (darkstat-configuration
>> +    (interface "eth0")))
>
> This should be aligned to the right.  Also perhaps s/eth0/eno1/ to match
> common names.
>
>> address@hidden @code{package} (default: @code{darstat})
>                                           ^
> Typo.
>
>> address@hidden @code{bindaddr} (default: @code{"127.0.0.1"})
>
> I’d prefer “address” or “listen-address” or “bind-address” (likewise in
> the code.)
>
> Otherwise LGTM, thank you!

Done, thanks for the review!