[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29741: [PATCH 2/2] gnu: services: web: Add service for httpd.
From: |
Christopher Baines |
Subject: |
bug#29741: [PATCH 2/2] gnu: services: web: Add service for httpd. |
Date: |
Wed, 17 Jan 2018 08:45:24 +0000 |
User-agent: |
mu4e 0.9.18; emacs 25.3.1 |
Ludovic Courtès <address@hidden> writes:
> Hi Chris!
>
> Sorry for the delay.
>
> Christopher Baines <address@hidden> skribis:
>
>> * gnu/services/web.scm (<httpd-module>,
>> <httpd-config-file>, <httpd-virtualhost>
>> <httpd-configuration>): New record types.
>> (%default-httpd-modules, %httpd-accounts,
>> httpd-service-type): New variables.
>> (httpd-shepherd-services, httpd-activation,
>> httpd-process-extensions): New procedures.
>> * gnu/tests/web.scm (run-httpd-test): New procedure.
>> (%httpd-os, %tests-httpd): New variables.
>> * doc/guix.texi (Web Services): Document the Apache HTTP Server.
>
> [...]
>
>> +The @code{(gnu services web)} module provides the Apache HTTP Server,
>> +the nginx web server, and also a fastcgi wrapper daemon.
>> +
>> address@hidden Apache HTTP Server
>> +
>> address@hidden {Scheme Variable} httpd-service-type
>> +Service type for the @uref{https://httpd.apache.org/,Apache HTTP}
>> +server. The value for this service type is a @code{https-configuration}
> ^
> Maybe add “(@dfn{httpd})”.
>
> Apart from this super-nitpicky comment, this LGTM! :-)
Great, I've made that change and pushed. Thanks for reviewing Ludo :)
signature.asc
Description: PGP signature