guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#30096] [PATCH 2/6] gnu: Add ocaml-integers.


From: Peter Kreye
Subject: [bug#30096] [PATCH 2/6] gnu: Add ocaml-integers.
Date: Thu, 18 Jan 2018 23:32:48 -0600
User-agent: mu4e 0.9.18; emacs 25.3.1

Julien,

Thank you for all of the feedback, it is much appreciated.

Julien Lepiller writes:

> Actually, I forgot to ask, why disable tests?
>
> That's the same question for the rest of your patches too.

This package doesn't have any tests, which seems to be causing the 'check
phase to fail. Would it be better to use "#:tests? #f" or to delete the
'check phase?

> You don't need to replace the 'build phase. ocaml-build-system can find
> pkg/pkg.ml. You just need to use #:build-flags (list "build") to add
> arguments.
>
> That applies also to the rest of your patches.

Thank you for this info. I'll make sure to do this from now on.

> It's probably better to use "#:findlib ,ocaml-findlib-1.7.3" in the
> arguments list.

Same.

--

Attachment: 0001-gnu-Add-ocaml-integers.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]