[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29536] [PATCH] gnu: Add cava.
From: |
Oleg Pykhalov |
Subject: |
[bug#29536] [PATCH] gnu: Add cava. |
Date: |
Thu, 25 Jan 2018 22:49:07 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello Ludovic,
Thank you for review!
address@hidden (Ludovic Courtès) writes:
>>>>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <address@hidden>
>> Date: Sat, 2 Dec 2017 22:36:36 +0300
>> Subject: [PATCH] gnu: Add cava.
>>
>> * gnu/packages/audio.scm (cava): New variable.
>
> [...]
>
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'bootstrap
>> + (lambda _
>> + (setenv "HOME" (getcwd))
>> + (zero? (system* "sh" "autogen.sh"))))
>
> Please use ‘invoke’ instead of ‘system*’.
This is new. OK, will use. Thank you for notice!
>> + (add-before 'build 'make-cava-ldflags
>> + (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out")
>> "/lib"))))
>
> Please use:
>
> (lambda* (#:key outputs #:allow-other-keys)
> … outputs …)
Should be this?
(lambda* (#:key outputs #:allow-other-keys)
… (assoc-ref outputs "out") …)
>> + (add-after 'install 'data
>> + (lambda _ (for-each (lambda (file)
>> + (install-file file (string-append
>> + (assoc-ref %outputs "out")
>> + "/share/doc/examples")))
>> + (find-files "example_files")))))))
> Likewise.
OK.
>> + (home-page "https://karlstav.github.io/cava/")
>> + (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")
>
> Rather: “Console audio visualizer for ALSA, MPD, and PulseAudio”.
OK.
>> + (description "@code{cava} provides a command line audio visualizer for
>> +MPD, Alsa and Pulseaudio.")
>
> Based on their README:
>
> C.A.V.A. is a bar audio spectrum visualizer for the terminal using
> ALSA, MPD, PulseAudio, or a FIFO buffer as its input.
OK.
> OK with these changes, thank you!
Pushed as c2c0d66162152b05fc42fdd1be5f07b9eca3bc66
Oleg.
signature.asc
Description: PGP signature