guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#30201] [PATCH] Fix Solfege configuration skeleton


From: Ludovic Courtès
Subject: [bug#30201] [PATCH] Fix Solfege configuration skeleton
Date: Wed, 31 Jan 2018 23:55:55 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hey,

Nicolas Goaziou <address@hidden> skribis:

> Currently, Guix Solfege package replaces, in the skeleton configuration,
> hard-coded filenames to various sound players with hard-coded filenames
> to the same players in the store. I think this is no good.
>
> The first time it is run, Solfege copies the skeleton configuration in
> home directory, as a dot file. However, at some point, possibly long
> after you forget about this detail, initial inputs are GC'ed, leaving
> non-existing filenames in a now broken configuration. Once you realize
> it, you need to find the new inputs in the store, rinse and repeat.

Heh.

> One option would be to move players to propagated-inputs. Since they do
> not prevent Solfege from building, however, I think simply removing them
> from the package is enough. One can always add them to their profile if
> needed.

Does Solfege look for them in $PATH?  If it does, providing just the
basename of these programs like your patch does is perfect IMO.

>>From e30b919f03ad9b37123b96dc38c24d41e562a02a Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <address@hidden>
> Date: Sun, 21 Jan 2018 23:43:02 +0100
> Subject: [PATCH] gnu: solfege: Make configuration more robust to GC
>
> * gnu/packages/music.scm (solfege): Do not introduce store filenames in the
> configuration skeleton.
> [inputs]: Remove optional players.

LGTM!

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]