[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30358] [PATCH] gnu: Add gpxsee.
From: |
Danny Milosavljevic |
Subject: |
[bug#30358] [PATCH] gnu: Add gpxsee. |
Date: |
Mon, 5 Feb 2018 17:47:57 +0100 |
Hi Mathieu,
On Mon, 5 Feb 2018 15:21:08 +0100
Mathieu Othacehe <address@hidden> wrote:
> + (for-each (lambda (file)
> + (system* "lrelease" file))
> + (find-files "lang" "\\.ts"))
Please add comment that that's for translation.
> + (substitute* "src/config.h"
> + (("/usr/share/gpxsee")
> + (string-append
> + (assoc-ref outputs "out") "/share/gpxsee/")))
Why once with, once without slash at the end?
> + (zero?
> + (system* "qmake"
> + (string-append "PREFIX="
> + (assoc-ref outputs "out"))))))
Please use "invoke".
> + (synopsis "GPX file viewer and analyser")
> + (description
> + "GPXSee is a Qt-based GPS log file viewer and analyzer that supports
> GPX,
> +TCX, KML, FIT, IGC and NMEA files.")
"analyser" or "analyzer" ?
Otherwise LGTM!