[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30328] [PATCH] gnu: Add emacs-browse-at-remote-gnu.
From: |
Ludovic Courtès |
Subject: |
[bug#30328] [PATCH] gnu: Add emacs-browse-at-remote-gnu. |
Date: |
Wed, 07 Feb 2018 10:18:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hi Oleg,
Oleg Pykhalov <address@hidden> skribis:
> address@hidden (Ludovic Courtès) writes:
>
> > What about simply adding the patch to ‘emacs-browse-at-remote’ if
> > it’s committed upstream way?
>
> I'm sorry, what do you mean by “committed upstream way”?
I mean that the patch for Savannah support is already in the repository
of ‘browse-at-remote’, isn’t it? Which is to say that the next version
of ‘browse-at-remote’ will have that functionality.
> I kinda agree to move the patch to ‘emacs-browse-at-remote’, but if
> somebody want to upgrade it, maybe he will need to recreate a patch.
(“He” or “she”.)
I don’t know, won’t the next ‘browse-at-remote’ include it?
> > Also please make the .patch file name a bit shorter; see ‘guix lint’.
>
> Ouch, I missed this because of “GUIX_PACKAGE_PATH”. Usually I unset
> this when prepare a package for Guix collection, but forget this time.
>
> $ ./pre-inst-env env guix lint emacs-browse-at-remote-gnu
>
> $ ./pre-inst-env env GUIX_PACKAGE_PATH= guix lint emacs-browse-at-remote-gnu
> /home/natsu/src/guix-wip-emacs-browse-at-remote-gnu/gnu/packages/emacs.scm:6474:2:
> address@hidden:
> emacs-browse-at-remote-gnu-add-support-for-gnu-repositories.patch: file
> name is too long
> fetching CVE database for address@hidden [cve]...
Oh I see, interesting.
The output of ‘guix lint’ seems to be messy, too.
Thanks,
Ludo’.