[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for sou
From: |
Marius Bakke |
Subject: |
[bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files). |
Date: |
Thu, 22 Feb 2018 15:14:44 +0100 |
User-agent: |
Notmuch/0.26 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) |
Oleg Pykhalov <address@hidden> writes:
> Hello Guix,
>
> Licensecheck attempts to determine the license that applies to each file
> passed to it, by searching the start of the file for text belonging to various
> licenses.
Nice!
I've read through the series, and the only remark I have is that it's
better to use 'perl-license' rather than (package-license perl) (see the
comment in (guix licenses)). Probably won't be a problem any time soon,
but still.
Regarding the -2 variants, I assume other packages fail to build if they
are simply updated? It would be good to have comments about it in the
code.
Apart from that LGTM, thank you!
> Oleg Pykhalov (21):
> gnu: Add perl-test-filename.
> gnu: Add perl-path-iterator-rule.
> gnu: Add perl-pod-constants.
> gnu: Add perl-regexp-pattern.
> gnu: Add perl-regexp-pattern-license.
> gnu: Add perl-number-range.
> gnu: Add perl-string-copyright.
> gnu: Add perl-string-escape.
> gnu: Add perl-test-failwarnings.
> gnu: Add perl-data-section.
> gnu: Add perl-software-license.
> gnu: Add perl-extutils-depends.
> gnu: Add perl-b-hooks-op-check.
> gnu: Add perl-bareword-filehandles.
> gnu: Add perl-indirect.
> gnu: Add perl-lexical-sealrequirehints.
> gnu: Add perl-multidimensional.
> gnu: Add perl-test-roo.
> gnu: Add perl-universal-require.
> gnu: Add perl-strictures-2.
> gnu: Add licensecheck.
>
> gnu/local.mk | 1 +
> gnu/packages/license.scm | 158 ++++++++++++++++++++
> gnu/packages/perl-check.scm | 73 ++++++++++
> gnu/packages/perl.scm | 340
> ++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 572 insertions(+)
> create mode 100644 gnu/packages/license.scm
>
> --
> 2.15.1
signature.asc
Description: PGP signature
- [bug#30274] [PATCH 00/21] gnu: Add licensecheck (license checker for source files).,
Marius Bakke <=