guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK libra


From: Ludovic Courtès
Subject: [bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library.
Date: Wed, 07 Mar 2018 14:04:33 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Kei Kebreau <address@hidden> skribis:

> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
> flag.
> ---
>  gnu/packages/music.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 3709f10d1..e88c9f21f 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
>                      (("add_subdirectory\\(resources/music\\)") ""))))))
>      (build-system cmake-build-system)
>      (arguments
> -     '(#:tests? #f)) ; no check target
> +     '(#:tests? #f ; no check target
> +       #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))

I’d suggest adding a comment as to why this is needed.

Then I think you can go ahead and push it.  If it fixes a use case for
you, that’s already an improvement.

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]