[Gzz-commits] gzz doc/pegboard/vobcoorder_culling--humppake/p...

[Asko Soukka]

CVSROOT:        /cvsroot/gzz
Module name:    gzz
Changes by:     Asko Soukka <address@hidden>    02/11/12 01:37:57

Modified files:
        doc/pegboard/vobcoorder_culling--humppake: peg.rst 
        gfx/libcoords  : Coords.cxx 

Log message:
        fixing

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/gzz/gzz/doc/pegboard/vobcoorder_culling--humppake/peg.rst.diff?tr1=1.5&tr2=1.6&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/gzz/gzz/gfx/libcoords/Coords.cxx.diff?tr1=1.52&tr2=1.53&r1=text&r2=text

Patches:
Index: gzz/doc/pegboard/vobcoorder_culling--humppake/peg.rst
diff -u gzz/doc/pegboard/vobcoorder_culling--humppake/peg.rst:1.5 
gzz/doc/pegboard/vobcoorder_culling--humppake/peg.rst:1.6
--- gzz/doc/pegboard/vobcoorder_culling--humppake/peg.rst:1.5   Mon Nov 11 
10:39:27 2002
+++ gzz/doc/pegboard/vobcoorder_culling--humppake/peg.rst       Tue Nov 12 
01:37:57 2002
@@ -4,8 +4,8 @@
 
 :Authors:   Asko Soukka
 :Stakeholders: Tuomas Lukka
-:Date:     $Date: 2002/11/11 15:39:27 $
-:Revision: $Revision: 1.5 $
+:Date:     $Date: 2002/11/12 06:37:57 $
+:Revision: $Revision: 1.6 $
 :Status:   Current
 :Date-Created: 2002-11-05
 :Scope:    Minor
@@ -21,37 +21,29 @@
 Into ``gzz.vob.VobCoorder`` add::
 
        /** Creates a CullingCoordSys with distinct parent and test 
-        * coordinate systems. The CullingCoordSys works mainly as its
-        * parent CoordSys. Although, it will be drawn always when boxes 
-        * of its test and clip coordinate systems do intersect. When
-        * the boxes don't intersect, the CullingCoordSys should not be 
-        * drawn.
-        * @param parent ID of the coordinate system which points which 
-        *               points will be transformed, if CullingCoordSys 
+        * coordinate systems. Exluding the test for drawing, the 
+        * CullingCoordSys works like its parent CoordSys. 
+        *
+        * This coordsys will not necessarily be drawn if the boxes
+        * of the test and clip coordinate systems do not intersect.
+        * However, this is not guaranteed; the only thing guaranteed
+        * is that if the boxes of the test and clip coordinate systems
+        * *do* intersect, the CullingCoordsys will be drawn.
+        *
+        * @param parent ID of the coordinate system which points 
+        *               will be transformed, if CullingCoordSys 
         *               is shown
-        * @param test ID of the coordinate system which box is tested 
+        * @param test ID of the coordinate system whose box is tested 
         *             against the clip coordinate system.
-        * @param clip ID of the coordinate system which box is tested
+        * @param clip ID of the coordinate system whose box is tested
         *             against the test coordinate system.
         */
        public int cull(int parent, int test, int clip) {
        }
 
        /** Creates a CullingCoordSys using the parent also as the test 
-        * coordinate system. In practise, this could be only a shorthand, 
-        * which returns a call cull(parent, parent, clip).
+        * coordinate system. 
         */
        public int cull(int parent, int clip) {
+         cull(parent, parent, clip);
        }
-
-After changing ``gzz.vob.VobCoorder`` these methods should also be 
-implemented in all implementing classes, which inherit 
-``gzz.vob.VobCoorder``. Because culling is already implemented in 
-``gzz.gfx.gl.GLVobCoorder``, currently classes left seem to be:
-
-* ``gzz.vob.impl.OrthoCoorder``
-  
-  **NOTE:** ``CullingCoordsys`` is currently implemented only on the
-  C++ side, but ``OrthoCoorder`` is not allowed to use JNI. *Dummy*
-  ``CullingCoordSys`` can be implented on the Java side as 
-  ``translate(parent, 0, 0)``.
Index: gzz/gfx/libcoords/Coords.cxx
diff -u gzz/gfx/libcoords/Coords.cxx:1.52 gzz/gfx/libcoords/Coords.cxx:1.53
--- gzz/gfx/libcoords/Coords.cxx:1.52   Fri Nov  8 07:31:39 2002
+++ gzz/gfx/libcoords/Coords.cxx        Tue Nov 12 01:37:57 2002
@@ -880,7 +880,7 @@
        /** Finds the bounding box of coordsys' box after
         * transformation. Assumes linear coordsys and transforms only
         * corner's of the box.
-        * @param cs the coordinate system, which box to use
+        * @param cs the coordinate system, whose box to use
         * @param p1 "lower left corner"
         * @param p2 "upper right corner"
         */
@@ -912,7 +912,7 @@
        /** Finds the bounding box of coordsys' box after
         * transformation. Because the coordsys may be distorted,
         * searches bounding box's coners also along vertices.
-        * @param cs the coordinate system, which box to use
+        * @param cs the coordinate system, whose box to use
         * @param p1 "lower left corner"
         * @param p2 "upper right corner"
         */