disallowing intial high-priority PRs

[Phil Edwards]

I've been informally requested to look into disallowing random anonymous
submitters from sending in PRs with the priority set to 'high'.  There's a
local policy that only the project maintainers have authority to set 'high'
priority (and thus steering the actions of a lot of people), and an annoying
number of the PRs showing up are from well-meaning people who feel their
specific problem is really really important.  (It is to /them/ but...)

Anyhow, I spewed out this hack.  Am I headed in the right direction?
(The problem with testing it is that the only gnatsd server available to
me is the one I'd eventually be modifying, i.e., no spare servers.)

Diff'd against stock 3.113 sources.


--- pr.c.orig   Tue Mar  2 19:18:54 1999
+++ pr.c        Wed Feb 28 16:37:48 2001
@@ -747,6 +747,16 @@
          if (verify_enum (i, pr[i].value, token))
            found = TRUE;
 
+          /* This hack prohibits random net submitters from submitting
+             a high-priority PR; the idea is that maintainers should be
+             the only ones permitted to raise priority to high.
+             This should be more configurable. */
+          if (found == TRUE && (!strcmp(pr[i].name,PRIORITY_STRING))
+                            && (!strcmp(pr[i].value,"high"))
+                            && (!strcmp(field_value(SUBMITTER),
+                                        pr[SUBMITTER].default_value)))
+            found = FALSE;
+
          if (found == FALSE)
            {
              if (check)



Any comments, flames, and suggestions would be highly appreciated.
Thanks for your time,

Phil

-- 
pedwards at disaster dot jaj dot com  |  pme at sources dot redhat dot com
devphil at several other less interesting addresses in various dot domains
The gods do not protect fools.  Fools are protected by more capable fools.