help-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: slow bibtex menu access


From: Stefan Monnier
Subject: Re: slow bibtex menu access
Date: Sat, 05 Mar 2005 16:27:00 -0500
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

> Thank you, I'd forgotten that (haven't done it in a long time). So I found
> the problem, and it was table.el. I had (require 'table) and (require
> 'emacs-wiki-table) (the latter requires table.el) in a few places. I have
> no idea where and how table.el is causing the problem, but would it be
> possible to turn it off (I guess a hook might do it) while in bibtex?
> Tables are not needed in bibtex anyway.

Setting debug-on-quit and hitting C-g while the menu is being built
indicates that the time is actually spent in table--find-row-column.

Looking some more at the table.el code, it seems there is a minor
logic-thinko bug in it.  Can you try the patch below (it's against the
Emacs-CVS version of table.el, so you may have to apply the patch by hand).

Tak, is my reasoning correct that `table--probe-cell' should return non-nil
iff we're inside a table?


        Stefan


--- orig/lisp/textmodes/table.el
+++ mod/lisp/textmodes/table.el
@@ -1025,13 +1025,13 @@
       :help "Insert a text based table at point"]
      ["Row" table-insert-row
       :active (and (not buffer-read-only)
-                  (or (table--probe-cell)
+                  (and (table--probe-cell)
                       (save-excursion
                         (table--find-row-column nil t))))
       :help "Insert row(s) of cells in table"]
      ["Column" table-insert-column
       :active (and (not buffer-read-only)
-                  (or (table--probe-cell)
+                  (and (table--probe-cell)
                       (save-excursion
                         (table--find-row-column 'column t))))
       :help "Insert column(s) of cells in table"])
@@ -1077,13 +1077,13 @@
     ("Insert"
      ["Row" table-insert-row
       :active (and (not buffer-read-only)
-                  (or (table--probe-cell)
+                  (and (table--probe-cell)
                       (save-excursion
                         (table--find-row-column nil t))))
       :help "Insert row(s) of cells in table"]
      ["Column" table-insert-column
       :active (and (not buffer-read-only)
-                  (or (table--probe-cell)
+                  (and (table--probe-cell)
                       (save-excursion
                         (table--find-row-column 'column t))))
       :help "Insert column(s) of cells in table"])


reply via email to

[Prev in Thread] Current Thread [Next in Thread]