Re: image-dired shows images as text

[Nick Roberts]

 > I am using Emacs 22.1 on Windows XP like the OP. When I type M-x
 > thumbs-dired-show-marked I just get empty squares displayed four rows
 > wide. I marked six images and I got one row of four squares and a second row
 > of two squares, all blank. I have tried M-x thumbs before and got similar
 > results (namely, a block of sixteen empty boxes). I have also added the
 > ImageMagick directory to the exec-path variable via a customization window,
 > but unfortunately it did not help.

I've checked the change below into CVS.  If Emacs can't find convert it should
now say so with this patch.  Can you please try to apply it and then post what
Emacs says to the mailing list.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** thumbs.el.~1.35.~   2007-07-27 09:22:25.000000000 +1200
--- thumbs.el   2007-12-28 21:01:18.000000000 +1300
*************** ARG any arguments to the ACTION command,
*** 248,262 ****
  OUTPUT-FORMAT is the file format to output (default is jpeg),
  ACTION-PREFIX is the symbol to place before the ACTION command
                (defaults to '-' but can sometimes be '+')."
!   (let ((command (format "%s %s%s %s \"%s\" \"%s:%s\""
!                        thumbs-conversion-program
!                        (or action-prefix "-")
!                        action
!                        (or arg "")
!                        filein
!                        (or output-format "jpeg")
!                        fileout)))
!     (call-process shell-file-name nil nil nil shell-command-switch command)))
  
  (defun thumbs-new-image-size (s increment)
    "New image (a cons of width x height)."
--- 248,259 ----
  OUTPUT-FORMAT is the file format to output (default is jpeg),
  ACTION-PREFIX is the symbol to place before the ACTION command
                (defaults to '-' but can sometimes be '+')."
!   (call-process thumbs-conversion-program nil nil nil
!               (or action-prefix "-")
!               action
!               (or arg "")
!               filein
!               (format "%s:%s" (or output-format "jpeg") fileout)))
  
  (defun thumbs-new-image-size (s increment)
    "New image (a cons of width x height)."