Re: `save-excursion' defeated by `set-buffer'

[Andreas Röhler]

Am 14.03.2011 15:25, schrieb Stefan Monnier:
> > Ok, how about
> >     "save-current-buffer is a better choice than save-excursion"
>
> Hmm, indeed, maybe the message should simply say
>
>    "Use with-current-buffer instead of save-excursion+set-buffer"
>
> > I only wish that the compiler warning was there 20 years ago so that
> > I wouldn't have to deal with that mess now.
>
> Oh yes!
>
>
>          Stefan

Hi Stefan,

pointing to other ways of delivering a task doesn't prove

save-excursion+set-buffer

is wrong.

Nonewithstanding there are better resp. lesser good coding styles.
Always welcome a discussion of code quality.

As far it concerns the compiler, please have a look how many warnings 
the last release issues when compiling.

In the result people will ignore that plenty of warnings.
Or might say: thats not worth a release if so many bugs are left.

That's going bad that way.

Whilst Emacs 24 alltogether seems coming forward considerably and is 
used in daily work here - thanks BTW.

Andreas