help-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 24.1.50 + lexical-binding + server.el + server-visit-hook = problem


From: Stefan Monnier
Subject: Re: 24.1.50 + lexical-binding + server.el + server-visit-hook = problem
Date: Mon, 25 Jun 2012 19:03:11 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

>>> Thanks for your thoughts.  Given the lack of discussion in this
>>> thread, I get the idea I'm the only person doing anything like this.
>> Maybe, but I'd still accept a patch that makes it easier,
> When you say "I'd accept a patch", does that mean you are willing to
> put such a thing in, assuming the patch is OK?

Yes.

> If so, how about this diff against the server.el from 24.1:
> diff server.el.orig server.el      
> 1131c1131,1133
> <                  (setq dir (command-line-normalize-file-name dir)))
> ---
> > (setq dir (command-line-normalize-file-name dir))
> > (process-put proc 'emacsclient-cwd dir)
> > )

"diff -u" is a better choice for output format, but thanks.
The patch looks good, I installed it in Emacs's trunk.

> In my tests, that does what I want.  I'm not in love with the name
> "emacsclient-cwd", so if there is something which is seen as a better
> name, that's find with me.

I've changed it to `server-client-directory' (the "server-" part is
just a kind of "module name prefix").


        Stefan


reply via email to

[Prev in Thread] Current Thread [Next in Thread]