buffer-local-value confusion

[Eric Abrahamsen]

I have defined a buffer-local variable like this:

(defvar nngnorb-attachment-file-list nil)
(make-variable-buffer-local 'nngnorb-attachment-file-list)

I'm first setting a value for it in the buffer referred to by
nnir-tmp-buffer, then trying to copy that buffer-local value to a
different buffer. Here's what I'm seeing, which confuses me:

(with-current-buffer (get-buffer nnir-tmp-buffer)
  nngnorb-attachment-file-list) --> proper, populated value

(buffer-local-value
 nngnorb-attachment-file-list
 (get-buffer nnir-tmp-buffer)) --> nil

I thought this was the whole point of buffer-local-value? Am I doing it
wrong?

On the other hand, using with-current-buffer is almost precisely the
same number of characters as buffer-local-value, so maybe there's no
point in insisting on the latter...

Eric