Re: elisp newbie: simplifying from cl structures?

[Tory S. Anderson]

Thanks for helping me straighten the code out and gain better understanding 
cl-tools and structure; it loads and mostly works. Thanks!

--8<---------------cut here---------------start------------->8---
(defun change-smtp ()
  "Change the SMTP server according to the current from line."
  (save-excursion
    (cl-loop with from = (save-restriction
                           (message-narrow-to-headers)
                           (message-fetch-field "from"))
             for (address server port) in smtp-accounts
             do (if  (string-match address from)
                    (return (funcall 'set-smtp server port address))
                  (message "Failed to match %s with %s" address from))
             finally (error "Cannot infer SMTP information."))))

(add-hook 'message-send-mail-hook 'change-smtp)
--8<---------------cut here---------------end--------------->8---



"Pascal J. Bourguignon" <pjb@informatimago.com> writes:

> John Mastro <john.b.mastro@gmail.com> writes:
>
>>>     (defun change-smtp ()
>>>       "Change the SMTP server according to the current from line."
>>>       (save-excursion
>>>         (cl-loop with from = (save-restriction
>>>                                (message-narrow-to-headers)
>>>                                (message-fetch-field "from"))
>>>                  for (address server port) in smtp-accounts
>>>                  if (string-match address from)
>>>                  return (funcall 'set-smtp server port address))
>>>         (error "Cannot infer SMTP information.")))
>>
>> Second try. The return won't escape the `error' in the above.
>>
>>     (defun change-smtp ()
>>       "Change the SMTP server according to the current from line."
>>       (save-excursion
>>         (cl-loop with from = (save-restriction
>>                                (message-narrow-to-headers)
>>                                (message-fetch-field "from"))
>>                  for (address server port) in smtp-accounts
>>                  if (string-match address from)
>>                  return (funcall 'set-smtp server port address)
>>                  finally (error "Cannot infer SMTP information."))))
>
>     do (if  (string-match address from)
>         (return (funcall 'set-smtp server port address)))
>     finally (error "Cannot infer SMTP information.")
>
> will.