Re: gnus-icalendar errors in emacs 24.5 [timezone issue]

[Kostas Zorbadelos]

Kostas Zorbadelos <kzorba@otenet.gr> writes:

Hello,

time handling is never trivial, it seems.
When the calendar sender is in a different timezone, the extracted event
does not seem to be converted to my timezone.

I need more reading and understanding of the code to find out where the
issue is (e.g what exactly are start, end below in
(defmethod gnus-icalendar-event:org-timestamp ((event gnus-icalendar-event))
      ...
      (start (gnus-icalendar-event:start-time event))
      (end (gnus-icalendar-event:end-time event))
      ...
).

In case you have any ideas, or I am missing something, please share. 

Regards,
Kostas

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Jan Tatarik <jan.tatarik@gmail.com> writes:
>>
>>> How about this? It's a patch against the emacs-25 branch, I was not able
>>> to connect to the gnus git. 
>>
>> The Gnus git repository is now read-only (and only with anonymous
>> access).
>>
>>> diff --git a/lisp/gnus/gnus-icalendar.el b/lisp/gnus/gnus-icalendar.el
>>> index 4faef06..82a649f 100644
>>> --- a/lisp/gnus/gnus-icalendar.el
>>> +++ b/lisp/gnus/gnus-icalendar.el
>>> @@ -401,8 +401,8 @@ gnus-icalendar-event:org-timestamp
>>>           (end-time (format-time-string "%H:%M" end))
>>>           (end-at-midnight (string= end-time "00:00"))
>>>           (start-end-date-diff (/ (float-time (time-subtract
>>> -                                        (date-to-time end-date)
>>> -                                        (date-to-time start-date)))
>>> +                                        (org-time-string-to-time end-date)
>>> +                                        (org-time-string-to-time 
>>> start-date)))
>>
>> Yes, this seems to fix the problem.  I'll apply to emacs-25 and push.
>

--
Kostas Zorbadelos       http://gr.linkedin.com/in/kzorba