[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-gnu-radius] Login-Time bug?
From: |
Sergey Poznyakoff |
Subject: |
Re: [Help-gnu-radius] Login-Time bug? |
Date: |
Mon, 02 Jun 2003 17:11:46 +0300 |
> Jun 02 00:11:02: Auth.error: Outside allowed timespan: [JfG4Cfy] (from nas
> as5300-1) time allowed:
> Mo2300-0800,Tu2300-0800,We2300-0800,Th2300-0800,Fr2300-0800,Sa,Su
Hmm, I vaguely remember us discussing this in the list.
The timestring "Mo2300-0800" is interpreted as "Monday from 23:00 to
midnight and Tuesday from 00:00 to 08:00", which is semantically
correct if the time specification is given precedence over the weekday.
If it is not, it should be considered a bug. Attached is a patch that
fixes it.
Regards,
Sergey
Index: radiusd/timestr.c
===================================================================
RCS file: /cvsroot/radius/radius/radiusd/timestr.c,v
retrieving revision 1.10
diff -p -u -r1.10 timestr.c
--- radiusd/timestr.c 27 Nov 2001 12:13:36 -0000 1.10
+++ radiusd/timestr.c 2 Jun 2003 14:04:19 -0000
@@ -77,7 +77,7 @@ timespan_day(ts, day, start, stop)
if (stop < start) {
timespan_day(ts, day, start, DAYMIN);
- timespan_day(ts, (day+1)%7, 0, stop);
+ timespan_day(ts, day, 0, stop);
return;
}