[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Segfaults in authorization type setting.
From: |
Mats Erik Andersson |
Subject: |
Segfaults in authorization type setting. |
Date: |
Tue, 7 Aug 2012 22:26:22 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
The functions
shishi_cfg_clientkdcetype_set()
and
shishi_cfg_authorizationtype_set()
are both throwing segmentation faults every time
they are fed with constant value strings. The reason
is that they both depend on strtok_r() which must
be given writeable strings. Simple calls to xstrdup()
resolve this issue.
As a second matter, both functions always return SHISHI_OK.
This is not reasonable, so a change is implemented that returns
SHISHI_OK whenever at least one valid value was found and set
for the intended configuration entity.
Best regards,
Mats Erik Andersson
0002-Segfault-in-config-list-parsing.patch
Description: Text Data
- Segfaults in authorization type setting.,
Mats Erik Andersson <=