Bug#924123: shishi: FTBFS with gcc 8.3

[Santiago Vila]

Package: src:shishi
Version: 1.0.2-6.1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
test -x debian/rules
mkdir -p "."
CDBS WARNING:    DEB_DH_STRIP_ARGS is deprecated since 0.4.85
CDBS WARNING:    DEB_COMPRESS_EXCLUDE is deprecated since 0.4.85
set -e;   mv ./build-aux/config.guess ./build-aux/config.guess.cdbs-orig; cp 
--remove-destination /usr/share/misc/config.guess ./build-aux/config.guess;
set -e;   mv ./build-aux/config.sub ./build-aux/config.sub.cdbs-orig; cp 
--remove-destination /usr/share/misc/config.sub ./build-aux/config.sub;
dh_autoreconf 
Copying file build-aux/config.rpath
Copying file m4/codeset.m4
Copying file m4/glibc2.m4
Copying file m4/glibc21.m4
Copying file m4/intdiv0.m4
Copying file m4/intl.m4

[... snipped ...]

gtkdoc-mkhtml 2>&1 --help | grep  >/dev/null "\-\-verbose"; \
if test "$?" = "0"; then \
  if test "x" = "x1"; then \
    mkhtml_options="$mkhtml_options --verbose"; \
  fi; \
fi; \
gtkdoc-mkhtml 2>&1 --help | grep  >/dev/null "\-\-path"; \
if test "$?" = "0"; then \
  mkhtml_options="$mkhtml_options --path=\"/<<PKGBUILDDIR>>/doc/reference\""; \
fi; \
cd html && gtkdoc-mkhtml $mkhtml_options  shishi ../shishi-docs.sgml
gtkdoc-fixxref --module=shishi --module-dir=html 
--html-dir=/usr/share/gtk-doc/html 
Package glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'glib-2.0' found
touch html-build.stamp
make[4]: Leaving directory '/<<PKGBUILDDIR>>/doc/reference'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/doc'
Making all in extra
make[3]: Entering directory '/<<PKGBUILDDIR>>/extra'
Making all in pam_shishi
make[4]: Entering directory '/<<PKGBUILDDIR>>/extra/pam_shishi'
/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. 
-I../..  -I../../gl -I../../lib -I../../gl -I../../lib -Wdate-time 
-D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. 
-fstack-protector-strong -Wformat -Werror=format-security -c -o pam_shishi.lo 
pam_shishi.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../gl -I../../lib 
-I../../gl -I../../lib -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
-Werror=format-security -c pam_shishi.c  -fPIC -DPIC -o .libs/pam_shishi.o
pam_shishi.c: In function 'pam_sm_authenticate':
pam_shishi.c:185:48: warning: cast to pointer from integer of different size 
[-Wint-to-pointer-cast]
   pam_set_data (pamh, "shishi_setcred_return", (void *) retval, NULL);
                                                ^
pam_shishi.c:127:7: warning: ignoring return value of 'asprintf', declared with 
attribute warn_unused_result [-Wunused-result]
       asprintf ((char **) &msg[0].msg, "Password for address@hidden': ",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   shishi_principal_default (h), shishi_realm_default (h));
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../gl -I../../lib 
-I../../gl -I../../lib -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
-Werror=format-security -c pam_shishi.c -o pam_shishi.o >/dev/null 2>&1
make[4]: *** [Makefile:1359: pam_shishi.lo] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/extra/pam_shishi'
make[3]: *** [Makefile:1272: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/extra'
make[2]: *** [Makefile:1440: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:1301: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [/usr/share/cdbs/1/class/makefile.mk:77: debian/stamp-makefile-build] 
Error 2
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit 
status 2
--------------------------------------------------------------------------------

The build was made in my autobuilder with "dpkg-buildpackage -A"
and it also fails here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/shishi.html

where you can get a full build log if you need it.

If this is really a bug in one of the build-depends, please use reassign and 
affects,
so that this is still visible in the BTS web page for this package.

Thanks.