|
From: | Paolo Bonzini |
Subject: | Re: [Help-smalltalk] ParseTreeRewriter refactoring |
Date: | Thu, 11 Jan 2007 11:44:48 +0100 |
User-agent: | Thunderbird 1.5.0.9 (Macintosh/20061207) |
I'm losing you a bit, but I think this would please me a lot more. Can you prepare the patch? (Sorry for the burden.)It's no problem. However, do you mean you want the reintroduced methods to call visitNodeList:visitor:onMatch:, or to be mostly copies of one another?
If you can eliminate "visitor:" keyword by having them be mostly copies, do it. If you can eliminate "visitor:" and not have them be mostly copies, even better...
I'll post a patch against the last version I have (which shouldn't conflict, as it would be stuck in the middle of code you want to keep) in 10 hours or so, after a good sleep.
Sure. I don't have a clue what time zone you are in, so... Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |