Re: [Help-smalltalk] STCompiler input bug?

[Holger Hans Peter Freyther]

On 09/24/2011 03:19 PM, Paolo Bonzini wrote:

> diff --git a/packages/stinst/parser/STCompiler.st 
> b/packages/stinst/parser/STCompiler.st
> index 620e019..4235d41 100644
> --- a/packages/stinst/parser/STCompiler.st
> +++ b/packages/stinst/parser/STCompiler.st
> @@ -795,6 +795,7 @@ indexed'' bytecode. The resulting stream is
>       | bc1 ret1 bc2 selector |
>       aNode arguments do: 
>               [:each | 
> +             each isBlock ifFalse: [^false].
>               (each arguments isEmpty and: [each body temporaries isEmpty]) 
>                   ifFalse: [^false].
>               bc1 isNil 

Hi,

I am now at two other issues:

1.)

PackageLoader fileInPackage: #Compiler; fileInPackage: #Sockets

Loading package Sockets
Object: 'CObject' error: did not understand #value
Smalltalk.MessageNotUnderstood(Smalltalk.Exception)>>signal (ExcHandling.st:254)
Smalltalk.String(Smalltalk.Object)>>doesNotUnderstand: #value 
(SysExcept.st:1442)
Smalltalk.CType>>cObjectType (CType.st:227)
Smalltalk.CType>>storeOn: (CType.st:260)
Smalltalk.WriteStream(Smalltalk.Stream)>>store: (Stream.st:510)
Smalltalk.CPtrCType>>storeOn: (CType.st:363)
Smalltalk.WriteStream(Smalltalk.Stream)>>store: (Stream.st:510)
[] in CAddrInfoStruct class(Smalltalk.CCompound
class)>>declaration:inject:into: (CStruct.st:164)
Smalltalk.Array(Smalltalk.SequenceableCollection)>>do: (SeqCollect.st:827)
CAddrInfoStruct class(Smalltalk.CCompound class)>>declaration:inject:into:
(CStruct.st:147)
CAddrInfoStruct class(Smalltalk.CStruct class)>>declaration: (CStruct.st:249)
Smalltalk.UndefinedObject>>executeStatements (source not available:1)
[] in STInST.STEvaluationDriver>>evaluate:
(Parser.star#VFS.ZipFile/STEvaluationDriver.st:210)
PackageLoader


2.)

If sockets is loaded by gst-remote before the Compiler package when loading
the OsmoMSC... I end with:

PackageLoader fileInPackage: #Sockets; fileInPackage: #Compiler;
fileInPackage: #OsmoMSC


Loading package OsmoCore
Loading package OsmoLogging
Loading package OsmoMGCP
Object: RBVariableNode new "<0x403fa060>" error: did not understand #arguments
Smalltalk.MessageNotUnderstood(Smalltalk.Exception)>>signal (ExcHandling.st:254)
STInST.RBVariableNode(Smalltalk.Object)>>doesNotUnderstand: #arguments
(SysExcept.st:1442)
STInST.STCompiler>>compileLoop: (Parser.star#VFS.ZipFile/STCompiler.st:783)
STInST.STCompiler>>acceptMessageNode: 
(Parser.star#VFS.ZipFile/STCompiler.st:647)



aNode: 'RBMessageNode(self lastUsed + 1 to: ports size do: alloc)'
^^^^^^^^^^^^

        (block arguments size = 1 and: [block body temporaries isEmpty])
            ifFalse: [^false].

so it needs a similar check if it is a block... or can act like a block?






STInST.RBMessageNode>>acceptVisitor:
(Parser.star#VFS.ZipFile/RBParseNodes.st:2092)
optimized [] in STInST.STCompiler>>compileStatements:
(Parser.star#VFS.ZipFile/STCompiler.st:566)
Smalltalk.OrderedCollection(Smalltalk.SequenceableCollection)>>keysAndValuesDo: 
(SeqCollect.st:887)
STInST.STCompiler>>compileStatements: 
(Parser.star#VFS.ZipFile/STCompiler.st:559)
STInST.STCompiler>>acceptMethodNode: (Parser.star#VFS.ZipFile/STCompiler.st:468)
STInST.RBMethodNode>>acceptVisitor: 
(Parser.star#VFS.ZipFile/RBParseNodes.st:1420)
STInST.STCompiler(STInST.RBProgramNodeVisitor)>>visitNode:
(Parser.star#VFS.ZipFile/RBParseNodes.st:49)
STInST.STCompiler class>>compile:asMethodOf:classified:parser:environment:
(Parser.star#VFS.ZipFile/STCompiler.st:161)
STInST.STCompiler class>>compile:asMethodOf:classified:parser:
(Parser.star#VFS.ZipFile/STCompiler.st:152)
STInST.STCompiler class>>compile:for:classified:parser:
(Parser.star#VFS.ZipFile/STCompiler.st:142)
STInST.STEvaluationDriver>>compile:
(Parser.star#VFS.ZipFile/STEvaluationDriver.st:192)
STInST.GSTFileInParser(STInST.STFileParser)>>compile:
(Parser.star#VFS.ZipFile/STFileParser.st:91)
STInST.GSTFileInParser>>parseMethodSource:on:
(Parser.star#VFS.ZipFile/GSTParser.st:320)
STInST.GSTFileInParser>>parseMethodSource:
(Parser.star#VFS.ZipFile/GSTParser.st:296)
STInST.GSTFileInParser>>parseClassBodyElement:withinExtend:
(Parser.star#VFS.ZipFile/GSTParser.st:230)
STInST.GSTFileInParser>>parseClassBody: 
(Parser.star#VFS.ZipFile/GSTParser.st:169)
STInST.GSTFileInParser>>parseClass: (Parser.star#VFS.ZipFile/GSTParser.st:157)
STInST.GSTFileInParser>>parseDeclaration:
(Parser.star#VFS.ZipFile/GSTParser.st:95)
STInST.GSTFileInParser>>parseDoit (Parser.star#VFS.ZipFile/GSTParser.st:82)
STInST.GSTFileInParser>>parseDoits (Parser.star#VFS.ZipFile/GSTParser.st:67)
STInST.GSTFileInParser(STInST.STFileInParser)>>parseSmalltalk
(Parser.star#VFS.ZipFile/STFileParser.st:282)
STInST.GSTFileInParser class(STInST.STFileParser
class)>>parseSmalltalkStream:with:onError:
(Parser.star#VFS.ZipFile/STFileParser.st:70)
STInST.GSTFileInParser class(STInST.STFileParser
class)>>parseSmalltalkStream:with: (Parser.star#VFS.ZipFile/STFileParser.st:60)
STInST.STEvaluationDriver(STInST.STParsingDriver)>>parseSmalltalkStream:with:
(Parser.star#VFS.ZipFile/STFileParser.st:181)
optimized [] in Smalltalk.Stream>>fileInLine:file:at:
(Compiler.star#VFS.ZipFile/StartCompiler.st:69)
Smalltalk.BlockClosure>>ensure: (BlkClosure.st:268)
Kernel.LimitedStream(Smalltalk.Stream)>>fileInLine:file:at:
(Compiler.star#VFS.ZipFile/StartCompiler.st:65)
Kernel.LimitedStream(Smalltalk.Stream)>>fileInLine:file:fileName:at:
(Compiler.star#VFS.ZipFile/StartCompiler.st:76)
Kernel.LimitedStream>>fileIn (VFSZip.st:352)
optimized [] in Smalltalk.FilePath>>fileIn (FilePath.st:662)
[] in VFS.StoredZipMember(Smalltalk.FilePath)>>withReadStreamDo: 
(FilePath.st:655)
Smalltalk.BlockClosure>>ensure: (BlkClosure.st:268)
VFS.StoredZipMember(Smalltalk.FilePath)>>withReadStreamDo: (FilePath.st:654)
VFS.StoredZipMember(Smalltalk.FilePath)>>fileIn (FilePath.st:662)
optimized [] in Smalltalk.Package>>primFileIn (PkgLoader.st:1564)
Smalltalk.OrderedCollection>>do: (OrderColl.st:67)
[] in Smalltalk.Package>>primFileIn (PkgLoader.st:1564)
Smalltalk.BlockClosure>>ensure: (BlkClosure.st:268)
Smalltalk.Package>>primFileIn (PkgLoader.st:1550)
Kernel.StarPackage>>primFileIn (PkgLoader.st:1076)
optimized [] in Smalltalk.PackageLoader class>>fileInPackages: 
(PkgLoader.st:1880)
Smalltalk.OrderedCollection>>do: (OrderColl.st:67)
Smalltalk.PackageLoader class>>fileInPackages: (PkgLoader.st:1873)
Smalltalk.PackageLoader class>>fileInPackage: (PkgLoader.st:1861)
Smalltalk.UndefinedObject>>executeStatements (a String:1)