help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] gst-sunit


From: Holger Hans Peter Freyther
Subject: Re: [Help-smalltalk] gst-sunit
Date: Mon, 8 Jul 2013 16:50:13 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jul 02, 2013 at 11:29:16AM +0200, Gwenaël Casaccio wrote:
> Hi,
> 
> I've extended gst-sunit to run sunit with a package description file
> thanks to the Holger patch.

look's great

>           | pkg |
> -         pkg := PackageLoader packageAt: arg.
> +            (arg endsWith: '.xml') 
> +                ifTrue: [ pkg := PackageLoader loadPackageFromFile: 
> Directory working / arg ]
> +                ifFalse: [ pkg := PackageLoader packageAt: arg ].

mixing tabs/spaces? I think paolo pointed me to a book of kent beck that
argued for

   pkg := (arg endsWith: '.xml')
           ifTrue: [PackageLoader ...]
           ifFalse: [PackageLoader ...]

if you agree i will make these changes and apply.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]