[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] gst-tool: Fix ASAN issue on comparing optio
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Help-smalltalk] [PATCH] gst-tool: Fix ASAN issue on comparing options |
|
Date: |
Wed, 8 Feb 2017 19:29:09 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 08/02/2017 15:51, Holger Freyther wrote:
>
>> On 8 Feb 2017, at 21:50, Holger Freyther <address@hidden> wrote:
>>
>
>
> Hi!
>
>> In case the name is longer than all_opts->name we would try to
>> read past the string. Start using strncmp and strlen to make
>> sure to fully consume all_opts->name and don't read out of
>> bounds.
>
> my inbox can't find this but I think we had this before? It is
> triggered by ASAN right away.
Wouldn't the '\0' mismatch first?
Paolo