|
From: | Lorenzo Bettini |
Subject: | Re: [Help-source-highlight] Embedding inputlang as information |
Date: | Sat, 09 Apr 2011 21:38:01 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Lightning/1.0b2 Thunderbird/3.1.8 |
On 04/04/2011 09:56 AM, Masatake YAMATO wrote:
Hi, thank you for replying.Hi there I still haven't had time to work on this. However, your patch looks OK. As I said in my previous email I think I will not add that additional argument in the constructor, but make it settable in a set method in order not to break compatibility, or probably add an overloaded constructor with the additional parameter.Implementing with the overloaded constructor aproach is much easier for me. I'll submit the patch.Instread of overloading, I've written a patch which uses default value for parameter.
thankshowever the signature of constructor and method have changed thus it is not backward-compatible. I'll deal with this when I apply the patch.
cheers Lorenzo -- Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino ICQ# lbetto, 16080134 (GNU/Linux User # 158233) HOME: http://www.lorenzobettini.it MUSIC: http://www.purplesucker.com http://www.myspace.com/supertrouperabba BLOGS: http://tronprog.blogspot.com http://longlivemusic.blogspot.com http://www.gnu.org/software/src-highlite http://www.gnu.org/software/gengetopt http://www.gnu.org/software/gengen http://doublecpp.sourceforge.net
[Prev in Thread] | Current Thread | [Next in Thread] |