Re: [Kawa-commonlisp-dev] [PATCH] DECLARE processing.

[Charles Turner]

Sorry for the lack of communication, it was my birthday yesterday, so
family had been visiting more than normal this week.

On 17 August 2012 01:48, Per Bothner <address@hidden> wrote:
> One problem is that a list is not always a sequence,
> and the iterator APIs are designed for sequences.
> Consider for example:
>   (declare (type integer . x))
> or:
>   (declare . y)
> These improper lists need to be handled with a sane error message.
> I think your code will throw a ClassCastException in some of these
> cases.

Ah, I'm pleased I asked now, I had a lot of cases like this that I was
oblivious too. Attached.

> I don't think it's that bad.  It's verbose, but at least it's obvious
> what is going on.  Better naming conventions would probably help.

Fair enough. I've tried to pick reasonable variable names, but it's a
tad subjective as to what they are..

Thanks for the explanations,

Charles.

declare.patch
Description: Binary data