kawa-commonlisp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.


From: Per Bothner
Subject: Re: [Kawa-commonlisp-dev] [PATCH] Type refactoring.
Date: Fri, 21 Sep 2012 17:24:24 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0

Thanks - I was thinking we needed to move forwards on this!
This looks like a reasonable-sized patch considering.

My biggest concern is the various uses of Scheme.getInstance().xxx()
It seem like these should be plain xxx() or (in the case of the
subclasses of Compilation) getLanguage.xxx().  Any reason why not?

It might also be help to add some comments - for example what is
the difference between getNamedType and string2Type.
--
        --Per Bothner
address@hidden   http://per.bothner.com/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]