[Koha-bugs] [Bug 511] New: "z3950 search" link always returns error, no popup window generated

[bugzilla-daemon]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=511

           Summary: "z3950 search" link always returns error, no popup
                    window generated
           Product: Koha
           Version: 2.0.0
          Platform: PC
        OS/Version: Linux - Redhat
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Acquisitions (Simple)
        AssignedTo: address@hidden
        ReportedBy: address@hidden
         QAContact: address@hidden


I am a newbie and would like apologize firsthand if I am doing something 
stupid and wasting the development team's time.  Anyway, I have the same 
problem with 1.9.3 and 2.0.0pre1.

English install of koha-2.0.0pre1 on RedHat 8 pc from scratch, I let the 
install script create a new empty database.  
Fixed /usr/local/koha/intranet/htdocs/intranet-
tmpl/default/en/acqui.simple/addbiblio.tmpl.
Copied z3950 scripts to correct directory, edited
/usr/local/koha/intranet/scripts/z3950daemon/z3950-daemon-shell.sh
and
/usr/local/koha/intranet/scripts/z3950daemon/z3950-daemon-launch.sh
to fix path environment variables.  Ran z3950-daemon-launch.sh from open shell 
seems to run without complaining.

aquistions = simple, marc = 1 (yes), marcflavour = MARC21
Using Internet Explorer 6.x on Win XP client

Many functions seem to work OK but except:

1. Log in to Intranet, click on Acquisitions (cgi-
bin/koha/acqui.simple/addbooks.pl), result OK
2. Enter valid ISBN in textbox on "To Add a new biblio/item" form, push GO 
button, result OK.
3.  Click on "Add New Biblio" link on Biblio Search Results (cgi-
bin/koha/acqui.simple/isbnsearch.pl?isbn=0812505158&title=)
4. MARC Biblio form is returned (cgi-bin/koha/acqui.simple/addbiblio.pl?
isbn=0812505158).
5. Click on "z3950 search" link and get (presumably JavaScript) runtime error 
on line 592; Error - Invalid argument.  No popup window.
6. Here are a few snippets from the html source retured by addbiblio.pl/tmpl

                <td width=10% align="center"><input type="hidden" name="op" 
value="addbiblio">
                                                                        
                        <input type="hidden" name="addfield_field">
                                                                        
                        <input type="hidden" name="oldbiblionumber" value="">
                                                                        
                        <input type="button" value="Add biblio" onClick='Check
(this.form)' accesskey="w">
                                                                        
                        <a href="javascript:PopupZ3950()">z3950 search</a>
                </td>


function PopupZ3950(link,i) {
    var strQuery="";
        for (i=0 ; i<document.forms[0].field_value.length ; i++) {
                if (document.forms[0].kohafield[i].value == "biblioitems.isbn" 
&& document.forms[0].field_value[i].value.length>0) {
                    strQuery += "&isbn="+document.forms[0].field_value
[i].value;
                }
                if (document.forms[0].kohafield[i].value == "biblio.title" && 
document.forms[0].field_value[i].value.length>0) {
                    strQuery += "&title="+document.forms[0].field_value
[i].value;
                }
                if (document.forms[0].kohafield[i].value == "biblio.author" 
&&document.forms[0].field_value[i].value.length>0) {
                    strQuery += "&author="+document.forms[0].field_value
[i].value;
                }
                if (document.forms[0].kohafield[i].value == "biblioitems.issn" 
&& document.forms[0].field_value[i].value.length>0) {
                    strQuery += "&issn="+document.forms[0].field_value
[i].value;
                }
        }
        newin=window.open("../z3950/search.pl?bibid="+strQuery,"z3950 
search",'width=500,height=400,toolbar=false,scrollbars=yes');
}

Is the PopupZ3950 funtion expecting parameters and getting none passed?  Where 
is the Link parameter even used in the function script?



------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.