[Koha-cvs] koha/C4 Acquisition.pm

[Antoine Farnault]

CVSROOT:        /sources/koha
Module name:    koha
Changes by:     Antoine Farnault <toins>        06/07/31 14:38:14

Modified files:
        C4             : Acquisition.pm 

Log message:
        Code cleaned.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/C4/Acquisition.pm?cvsroot=koha&r1=1.40&r2=1.41

Patches:
Index: Acquisition.pm
===================================================================
RCS file: /sources/koha/koha/C4/Acquisition.pm,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -b -r1.40 -r1.41
--- Acquisition.pm      27 Jul 2006 13:39:00 -0000      1.40
+++ Acquisition.pm      31 Jul 2006 14:38:14 -0000      1.41
@@ -17,7 +17,7 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-# $Id: Acquisition.pm,v 1.40 2006/07/27 13:39:00 toins Exp $
+# $Id: Acquisition.pm,v 1.41 2006/07/31 14:38:14 toins Exp $
 
 use strict;
 require Exporter;
@@ -30,7 +30,7 @@
 use vars qw($VERSION @ISA @EXPORT);
 
 # set the version for version checking
-$VERSION = do { my @v = '$Revision: 1.40 $' =~ /\d+/g; shift(@v) . "." . join( 
"_", map { sprintf "%03d", $_ } @v ); };
+$VERSION = do { my @v = '$Revision: 1.41 $' =~ /\d+/g; shift(@v) . "." . join( 
"_", map { sprintf "%03d", $_ } @v ); };
 
 # used in receiveorder subroutine
 # to provide library specific handling
@@ -304,17 +304,19 @@
 
 Looks up the order with the given biblionumber and biblioitemnumber.
 
-Returns a two-element array. C<$ordernumber> is the order number.
-C<$order> is a reference-to-hash describing the order; its keys are
-fields from the biblio, biblioitems, aqorders, and aqorderbreakdown
+Returns a two-element array.
+
+=item C<$ordernumber> is the order number.
+
+=item C<$order> is a reference-to-hash describing the order;
+its keys are fields from the biblio, biblioitems, aqorders, and 
aqorderbreakdown
 tables of the Koha database.
 
 =back
 
 =cut
-# @_ = biblioitemnumber, biblionumber.
 sub GetOrder {
-    my ( $bi, $bib ) = @_;
+    my ( $biblionumber,$biblioitemnumber ) = @_;
     my $dbh = C4::Context->dbh;
     my $query = "
         SELECT ordernumber
@@ -323,7 +325,7 @@
         AND    biblioitemnumber=?
     ";
     my $sth = $dbh->prepare($query);
-    $sth->execute( $bib, $bi );
+    $sth->execute( $biblionumber, $biblioitemnumber );
 
     # FIXME - Use fetchrow_array(), since we're only interested in the one
     # value.
@@ -668,8 +670,8 @@
 If C<$complete> is C<yes>, the results will include only completed
 orders. In any case, C<&ordersearch> ignores cancelled orders.
 
-C<&ordersearch> returns an array. C<@results> is an array of 
references-to-hash with the
-following keys:
+C<&ordersearch> returns an array.
+C<@results> is an array of references-to-hash with the following keys:
 
 =over 4
 
@@ -813,7 +815,7 @@
 @results = &GetParcel($booksellerid, $code, $date);
 
 Looks up all of the received items from the supplier with the given
-bookseller ID at the given date, for the given code. Ignores cancelled and 
completed orders.
+bookseller ID at the given date, for the given code (bookseller Invoice 
number). Ignores cancelled and completed orders.
 
 C<@results> is an array of references-to-hash. The keys of each element are 
fields from
 the aqorders, biblio, and biblioitems tables of the Koha database.
@@ -882,14 +884,33 @@
 
 =over 4
 
-$results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto, $limit);
+$results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto);
+get a lists of parcels.
+
+* Input arg :
+
+=item $bookseller
+is the bookseller this function has to get parcels.
+
+=item $order
+To know on what criteria the results list has to be ordered.
+
+=item $code
+is the booksellerinvoicenumber.
+
+=item $datefrom & $dateto
+to know on what date this function has to filter its search.
+
+* return:
+a pointer on a hash list containing parcel informations as such :
+
+=item Creation date
+
+=item Last operation
+
+=item Number of biblio
 
-get a lists of parcels
-Returns a pointer on a hash list containing parcel informations as such :
-        Creation date
-        Last operation
-        Number of biblio
-        Number of items
+=item Number of items
 
 =back
 
@@ -938,7 +959,7 @@
 
 @results = &GetLateOrders;
 
-Searches for suppliers with late orders.
+Searches for bookseller with late orders.
 
 return:
 the table of supplier with late issues. This table is full of hashref.