koha-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Koha-cvs] koha/koha-tmpl/intranet-tmpl/default/en/acqui.s... [rel_2_2]


From: Antoine Farnault
Subject: [Koha-cvs] koha/koha-tmpl/intranet-tmpl/default/en/acqui.s... [rel_2_2]
Date: Fri, 08 Sep 2006 09:07:45 +0000

CVSROOT:        /sources/koha
Module name:    koha
Branch:         rel_2_2
Changes by:     Antoine Farnault <toins>        06/09/08 09:07:45

Modified files:
        koha-tmpl/intranet-tmpl/default/en/acqui.simple: addbiblio.tmpl 

Log message:
        Fix a bug on default template when moving up a subfield in the marc 
editor.
        /!\ WARNING /!\ Joshua & owen => you may be have the same bug in npl 
template !

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/koha-tmpl/intranet-tmpl/default/en/acqui.simple/addbiblio.tmpl?cvsroot=koha&only_with_tag=rel_2_2&r1=1.33.2.31&r2=1.33.2.32

Patches:
Index: addbiblio.tmpl
===================================================================
RCS file: 
/sources/koha/koha/koha-tmpl/intranet-tmpl/default/en/acqui.simple/Attic/addbiblio.tmpl,v
retrieving revision 1.33.2.31
retrieving revision 1.33.2.32
diff -u -b -r1.33.2.31 -r1.33.2.32
--- addbiblio.tmpl      31 Aug 2006 14:07:18 -0000      1.33.2.31
+++ addbiblio.tmpl      8 Sep 2006 09:07:45 -0000       1.33.2.32
@@ -332,9 +332,30 @@
 }
 
 function upSubfield(index) {
-var original = document.getElementById(index);
-var previous = original.previousSibling;
-original.parentNode.insertBefore( original, previous );
+       try{
+               var line = document.getElementById(index); // get the line 
where the user has clicked.
+       } catch(e) {
+               return;
+       }
+       var tag = line.parentNode; // get the dad of this line. (should be 
"<div tag=XXX>")
+       
+       // getting all subfields for this tag
+       var subfields = tag.getElementsByTagName('div');
+       var subfieldsLength = subfields.length;
+       if(subfieldsLength<=1) return; // nothing to do if there is just one 
subfield.
+       // among all subfields 
+       for(var i=0;i<subfieldsLength;i++){ 
+               if(subfields[i].getAttribute('id') == index){ //looking for the 
subfield which is clicked :
+                       if(i==0){ // if the clicked subfield is on the top
+                               tag.appendChild(subfields[0]);
+                               return;
+                       }else{
+                               var lineAbove = subfields[i-1];
+                               tag.insertBefore(line,lineAbove);
+                               return;
+                       }
+               }
+       }
 }
 
 function unHideSubfield(index,labelindex) {




reply via email to

[Prev in Thread] Current Thread [Next in Thread]