Re: [ladcca] Warnings with include of list.h

[Josh Green]

On Wed, 2004-01-21 at 15:48, Bob Ham wrote:
> On Wed, 2004-01-21 at 22:41, Josh Green wrote:
> > I'm currently the maintainer for FluidSynth (http://www.fluidsynth.org)
> > and I was noticing that building with ladcca 0.4 causes some warnings to
> > be emitted. 
> 
> Did you apply the fluidsynth patch in the patches/ directory?
> 

No, should that be applied to fluidsynth CVS?

> > /usr/local/include/ladcca-1.0/ladcca/list.h:291: warning: inlining
> > failed in call to `cca_list_sort'
> > /usr/local/include/ladcca-1.0/ladcca/list.h:314: warning: called from
> > here
> > /usr/local/include/ladcca-1.0/ladcca/list.h:291: warning: inlining
> > failed in call to `cca_list_sort'
> > /usr/local/include/ladcca-1.0/ladcca/list.h:314: warning: called from
> > here
> 
> I've never had this before.  It'd imagine it would be optimiser- or
> compiler-build specific.  What version/arch of gcc?  What CFLAGS were
> used in the ladcca compile?  It's not anything to worry about, but if
> there are consistent warnings, something should probably be done about
> it.
> 

Yeah, I just thought I would mention it, it didn't seem to cause any
problems as you say. GCC 3.3.1, CFLAGS were just whatever standard ones
ladcca uses, I didn't do anything special. Currently, I'm too lazy to
track it down :)

> > Also, I have a question about the removal of CCA_Use_Jack/Alsa
> > constants. Is it sufficient to just remove these? Does this break
> > backwards compatibility, in other words if someone has LADCCA 0.3 will
> > it still work with this change?
> 
> CCA_Use_{Jack,Alsa} don't exist in 0.4.0, so it shouldn't compile. 
> They'll only work with 0.3.
> 
> >  Or should we now require 0.4 with FluidSynth?
> 
> You should require 0.4.0.
> 
> Cheers,
> 
> Bob 

Regards,
        Josh