[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libcdio-devel] [PATCH] buffer overflow and fixes from static analys
From: |
Rocky Bernstein |
Subject: |
Re: [Libcdio-devel] [PATCH] buffer overflow and fixes from static analysis |
Date: |
Tue, 31 May 2011 14:31:46 -0400 |
On Tue, May 31, 2011 at 9:50 AM, Honza Horak <address@hidden> wrote:
> On 05/30/2011 09:27 PM, Rocky Bernstein wrote:
>
>> The patches you attached have been applied with some changes.
>>
>> Some changes were needed because you patched against the last release
>> version rather than the current git sources.
>>
>> One change to lib/driver/gnu_linux.c was:
>> + if ( mnt_dev&& mnt_dev ) {
>>
>> which is weird to test against the same thing. I assume you meant:
>> + if ( mnt_type&& mnt_dev ) {
>>
>
> Yes, that was a mistake.
>
>
> I don't have the Coverty static analysis tool. So please check over the
>> current git sources to see if brings up any problems that might have been
>> introduced since 0.82 or in my applying the patches with changes.
>>
>
> The attached file libcdio-20110531-hhorak.patch fixes another two issues
> found in current git source.
>
Patches applied in git. Again, thanks.
>
> Nevertheless, there are more problems reported by Coverity, but the rest of
> them I consider not relevant or even false positive. The log is attached for
> further investigation too.
>
> Cheers,
>
> Honza
>