Re: [libcvd-members] convert_image mess

[E. Rosten]

On Sun, 11 Jan 2009, Georg Klein wrote:

> Hi,
>
> I'm absolutely lost in what the deal is with
> convert_image vs ConvertImage vs convert, and also there seem to be different 
> version of convert_image for SubImage and BasicImage?

convert_image is the function call one uses to convert images from one 
type to another. ConvertImage is the templated struct which deals with 
conversions between Rgb, Rgba and grey. Mostly, covtert_image will use 
ConvertImage to perform the conversion.

colourspace_convert also has some specializations of the convert_image 
function for other types, such as yuv411.

The prototypes ought to all be SubImage, but some of the asm routines, 
such as yuv411_to_stuff_MMX.C assume that images are contiguous, so they 
won't work for SubImages.

> Whatever the plan, ColourspaceBuffer<Rgb<byte>, yuv411> no longer seems to 
> work - it's not getting the conversions from colourspace_convert.h any more.

Fixed.

> It wants pixel traits for yuv411 which aren't defined.

Indeed. The pixel traits are to deduce the fine details of the conversion, 
such as maxvals, integral types. Yuv411 has a dedicated routine to do the 
conversion, so traits aren't needed.

-Ed

--
(You can't go wrong with psycho-rats.)(http://mi.eng.cam.ac.uk/~er258)

/d{def}def/f{/Times s selectfont}d/s{11}d/r{roll}d f 2/m{moveto}d -1
r 230 350 m 0 1 179{ 1 index show 88 rotate 4 mul 0 rmoveto}for/s 12
    d f pop 235 420 translate 0 0 moveto 1 2 scale show showpage