[libextractor] RE: duplicate "software" fields for image/x-canon-cr2

[David Lasker]

Hi Christian

Yes that seems to help. Now extract displays the following for a cr2 file:

creation date - 2009:01:23 13:14:20
source - Canon EOS DIGITAL REBEL XSi
size - 2256x1504
mimetype - image/tiff

I still need to test with Mediatomb, but I assume libextractor will report
the creation date field with EXTRACTOR_CREATION_DATE, so I am pretty sure my
problem is solved.

Is this a bug that should be permanently fixed, or will changing the code
break something for "real" tiff files? In other words, was there some good
reason for the use of EXTRACTOR_SOFTWARE in the original code?

Thanks for the help!

Dave
-----Original Message-----
From: Christian Grothoff [mailto:address@hidden 
Sent: Wednesday, April 08, 2009 11:00 AM
To: David Lasker
Subject: duplicate "software" fields for image/x-canon-cr2

Hi!

I got your e-mail, however somehow I lost the admin password for the 
mailinglist so it is blocked there (hopefully that'll be fixed soon).

Anyway, in the meantime, could you try if the following patch fixes your 
problem?

--- tiffextractor.c     (revision 8312)
+++ tiffextractor.c     (working copy)
@@ -102,7 +102,7 @@
   if (data[entry->value_or_offset + entry->count - 1] != 0)
     return;
   addKeyword (prev,
-              strdup (&data[entry->value_or_offset]), EXTRACTOR_SOFTWARE);
+              strdup (&data[entry->value_or_offset]), type);
 }


Best,

Christian
-- 
Christian Grothoff
Assistant Professor
Department of Computer Science
University of Denver