[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix LTO builds of libntml with gcc 8
From: |
Simon Josefsson |
Subject: |
Re: Fix LTO builds of libntml with gcc 8 |
Date: |
Fri, 24 Aug 2018 21:49:28 +0200 |
mån 2018-02-26 klockan 18:29 +0000 skrev Romain GEISSLER:
> Hi,
>
> I am having troubles to build libntml with LTO support and gcc 8. The
> reason is, md4 symbols are both embedded in libntml.so and libgnu.a,
> and your test binary uses both. To fix that, I use a convenient
> library (ie non delivered static library) that is used both to
> implement libntml and can be correctly used in the tests, without LTO
> being confused by having the same symbols both in a shared library
> and in a static library. This patch was tested agains the 1.4
> tarball:
Hi again Romain. I have applied your patch.
Thanks,
/Simon
>
> Cheers,
> Romain
>
> --- Makefile.am
> +++ Makefile.am
> @@ -28,6 +28,7 @@
> pkgconfigdir = $(libdir)/pkgconfig
> pkgconfig_DATA = libntlm.pc
>
> +noinst_LTLIBRARIES = libntlm_impl.la
> lib_LTLIBRARIES = libntlm.la
>
> include_HEADERS = ntlm.h
> @@ -35,17 +36,18 @@
> AM_CFLAGS = $(WARN_CFLAGS)
> AM_CPPFLAGS = -I$(srcdir)/gl -I$(builddir)/gl
> -DNTLM_SRCDIR=\"$(srcdir)\"
>
> -libntlm_la_SOURCES = smbutil.c smbencrypt.c
> +libntlm_impl_la_SOURCES = smbutil.c smbencrypt.c
> +libntlm_la_SOURCES =
> libntlm_la_LDFLAGS = -version-info
> $(LT_CURRENT):$(LT_REVISION):$(LT_AGE) \
> -export-symbols-regex '^(dumpSmb|buildSmb|ntlm_).*' -no-
> undefined
>
> -libntlm_la_LIBADD = gl/libgnu.la
> +libntlm_la_LIBADD = libntlm_impl.la gl/libgnu.la
>
> # test
>
> TESTS = test_ntlm
> check_PROGRAMS = $(TESTS)
> -LDADD = libntlm.la gl/libgnu.la
> +LDADD = libntlm_impl.la gl/libgnu.la
> CLEANFILES = test.out
> test_ntlm_LDFLAGS = -no-install
>
>
>
> _______________________________________________
> Libntlm mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/libntlm
signature.asc
Description: This is a digitally signed message part
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Fix LTO builds of libntml with gcc 8,
Simon Josefsson <=