libtasn1-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] GNU libtasn1 branch, master, updated. libtasn1_3_4-10-g960d3db


From: Nikos Mavrogiannopoulos
Subject: [SCM] GNU libtasn1 branch, master, updated. libtasn1_3_4-10-g960d3db
Date: Fri, 28 Mar 2014 13:45:39 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU libtasn1".

http://git.savannah.gnu.org/cgit/libtasn1.git/commit/?id=960d3dbed1c332c4a978004b2899cbe3e7bc7904

The branch, master has been updated
       via  960d3dbed1c332c4a978004b2899cbe3e7bc7904 (commit)
       via  d2ae7d7e3cd78652f5a08437d7e30adac575cad4 (commit)
       via  f71df370925373a2e69aafa6b0b16916eb7ad1ef (commit)
      from  0b1cce8661cbdbb17d2c53ea314d442567bc508d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 960d3dbed1c332c4a978004b2899cbe3e7bc7904
Author: Nikos Mavrogiannopoulos <address@hidden>
Date:   Fri Mar 28 14:45:33 2014 +0100

    cleaned up code

commit d2ae7d7e3cd78652f5a08437d7e30adac575cad4
Author: Jean-Louis Thekekara <address@hidden>
Date:   Tue Mar 25 13:41:37 2014 +0100

    asn1_write_value: allow SET_OF elements deletion
    
    SET_OF elements could just be deleted as SEQUENCE_OF ones.
    
    Signed-off-by: Nikos Mavrogiannopoulos <address@hidden>

commit f71df370925373a2e69aafa6b0b16916eb7ad1ef
Author: Jean-Louis Thekekara <address@hidden>
Date:   Tue Mar 25 14:16:39 2014 +0100

    extract_tag_der_recursive: fix compilation errors
    
    Fix the following errors introduced by extract_tag_der_recursive usage:
    
    decoding.c: In function 'extract_tag_der_recursive':
    decoding.c:560:5: error: 'ris' may be used uninitialized in this function 
[-Werror=maybe-uninitialized]
    
    decoding.c: In function 'asn1_der_decoding_startEnd':
    decoding.c:2192:40: error: unused variable 'p3' [-Werror=unused-variable]
    
    Signed-off-by: Nikos Mavrogiannopoulos <address@hidden>

-----------------------------------------------------------------------

Summary of changes:
 lib/decoding.c      |    4 ++--
 lib/element.c       |    2 +-
 tests/Test_choice.c |    3 +--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/lib/decoding.c b/lib/decoding.c
index dee7a9f..e9af339 100644
--- a/lib/decoding.c
+++ b/lib/decoding.c
@@ -557,7 +557,7 @@ extract_tag_der_recursive(asn1_node node, const unsigned 
char *der, int der_len,
                       int *ret_len)
 {
 asn1_node p;
-int ris;
+int ris = ASN1_DER_ERROR;
 
   if (type_field (node->type) == ASN1_ETYPE_CHOICE)
     {
@@ -2189,7 +2189,7 @@ int
 asn1_der_decoding_startEnd (asn1_node element, const void *ider, int len,
                            const char *name_element, int *start, int *end)
 {
-  asn1_node node, node_to_find, p, p2, p3;
+  asn1_node node, node_to_find, p, p2;
   int counter, len2, len3, len4, move, ris;
   unsigned char class;
   unsigned long tag;
diff --git a/lib/element.c b/lib/element.c
index 8604c24..3e26d84 100644
--- a/lib/element.c
+++ b/lib/element.c
@@ -290,7 +290,7 @@ asn1_write_value (asn1_node node_root, const char *name,
 
   type = type_field (node->type);
 
-  if ((type == ASN1_ETYPE_SEQUENCE_OF) && (value == NULL) && (len == 0))
+  if ((type == ASN1_ETYPE_SEQUENCE_OF || type == ASN1_ETYPE_SET_OF) && (value 
== NULL) && (len == 0))
     {
       p = node->down;
       while ((type_field (p->type) == ASN1_ETYPE_TAG)
diff --git a/tests/Test_choice.c b/tests/Test_choice.c
index 7c41837..07da57e 100644
--- a/tests/Test_choice.c
+++ b/tests/Test_choice.c
@@ -3,12 +3,11 @@
 #include <libtasn1.h>
 
 int
-main ()
+main (int argc, char** argv)
 {
   int result = 0;
   asn1_node definitions = NULL, node1 = NULL, node2 = NULL;
   char errorDescription[ASN1_MAX_ERROR_DESCRIPTION_SIZE];
-  unsigned i;
 
   char data[1024];
   int data_size = sizeof (data);


hooks/post-receive
-- 
GNU libtasn1



reply via email to

[Prev in Thread] Current Thread [Next in Thread]