[SCM] GNU Libtool branch, master, updated. v2.2.8-13-ge0c89b9

[Ralf Wildenhues]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Libtool".

The branch, master has been updated
       via  e0c89b9a0768516b8f67a33af15838679821ee3b (commit)
      from  eb399e6a03d7a536079eb90ff55dcc4043c949e4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e0c89b9a0768516b8f67a33af15838679821ee3b
Author: Ralf Wildenhues <address@hidden>
Date:   Tue Jun 8 21:23:08 2010 +0200

    Fix testsuite helper macros to not hide failure.
    
    * tests/testsuite.at (LT_AT_CONFIGURE, LT_AT_MAKE):
    Do not wrap AT_CHECK in a subshell, so that failures are
    properly propagated; instead, move environment changes inside
    the AT_CHECK code.
    Report and analysis by Peter Rosin.
    
    Signed-off-by: Ralf Wildenhues <address@hidden>

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog          |    7 +++++++
 tests/testsuite.at |   16 +++++++---------
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f1a58fa..0ce3ca0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2010-06-08  Ralf Wildenhues  <address@hidden>
 
+       Fix testsuite helper macros to not hide failure.
+       * tests/testsuite.at (LT_AT_CONFIGURE, LT_AT_MAKE):
+       Do not wrap AT_CHECK in a subshell, so that failures are
+       properly propagated; instead, move environment changes inside
+       the AT_CHECK code.
+       Report and analysis by Peter Rosin.
+
        Avoid autom4te warning about unnamed diversion.
        * libltdl/config/getopt.m4sh: Use diversion name KILL not -1.
 
diff --git a/tests/testsuite.at b/tests/testsuite.at
index 7f9afe9..71b9dc4 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -151,21 +151,19 @@ AT_KEYWORDS([autoconf automake])
 # LT_AT_CONFIGURE([OPTIONS])
 # --------------------------
 m4_define([LT_AT_CONFIGURE],
-[( SHELL=${CONFIG_SHELL-/bin/sh}
-   AT_CHECK([CONFIG_SHELL=$SHELL $SHELL ./configure $configure_options $1],
-        [0], [ignore], [ignore])
- )
+[AT_CHECK([: ${CONFIG_SHELL=/bin/sh}; export CONFIG_SHELL; ]dnl
+         [$CONFIG_SHELL ./configure $configure_options $1],
+         [0], [ignore], [ignore])
 ])
 
 
 # LT_AT_MAKE([TGTS], [VARS])
 # --------------------------
 m4_define([LT_AT_MAKE],
-[( $unset LIBTOOL LIBTOOLIZE
-  for target in m4_default([$1], [all])
-  do
-    AT_CHECK([$MAKE $target $2], [0], [ignore], [ignore])
-  done )
+[for target in m4_default([$1], [all])
+do
+  AT_CHECK([$unset LIBTOOL LIBTOOLIZE; $MAKE $target $2], [0], [ignore], 
[ignore])
+done
 ])
 
 


hooks/post-receive
-- 
GNU Libtool