[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Building C++ libraries with GNU ld on HP-UX
From: |
Gary V . Vaughan |
Subject: |
Re: Building C++ libraries with GNU ld on HP-UX |
Date: |
Fri, 20 Apr 2001 18:29:14 +0100 |
On Friday 20 April 2001 9:34 am, Alexandre Oliva wrote:
> On Apr 18, 2001, "Gary V. Vaughan" <address@hidden> wrote:
> > On Wednesday 18 April 2001 5:53 am, Alexandre Oliva wrote:
> >> + if test ${with_gnu_ld} = no; then
> >
> > ^^^^^^^^^^^^^^
> > if test "x$with_gnu_ld" = xno; then
>
> It's guaranteed to be either yes or no.
Until someone forgets during a re-edit. I still prefer the belt and braces
approach. Come to think of it, I tend to prefer this kind of thing:
if test "x$with_gnu_ld" != xyes; then ...
The code is then robust to unexpected errors in the value of the tested
variable, and probably still does the right thing in that case. Anyway, I'm
just nit-picking -- don't let that stop you commiting the patch. ;-)
Cheers,
Gary.
--
___ _ ___ __ _ mailto: address@hidden
/ __|__ _ _ ___ _| | / / | / /_ _ _ _ __ _| |_ __ _ ___ address@hidden
| (_ / _` | '_|// / |/ /| |/ / _` | || / _` | ' \/ _` | _ \
\___\__,_|_|\_, /|___(_)___/\__,_|\_,_\__, |_||_\__,_|//_/
home page: /___/ /___/ gpg public key:
http://www.oranda.demon.co.uk http://www.oranda.demon.co.uk/key.asc