[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH: Work around libtool for `$' in filenames
From: |
H. J. Lu |
Subject: |
Re: PATCH: Work around libtool for `$' in filenames |
Date: |
Tue, 26 Nov 2002 20:31:37 -0800 |
User-agent: |
Mutt/1.2.5.1i |
On Wed, Nov 27, 2002 at 12:44:03AM -0200, Alexandre Oliva wrote:
> [Cc:ing libtool-patches, to make sure libtool maintainers are aware of
> the problem and don't end up rewriting this patch by mistake]
>
> On Nov 26, 2002, "H. J. Lu" <address@hidden> wrote:
>
> > Libtool couldn't deal with `$' in filenames, which is used in libjava
> > test. This patch seems to work for me.
>
> Sorry, this one can't go in. For one, it would break the libtool
> testsuite for disregarding $run, which would break libtool -n.
>
> This is probably a symptom of places where arguments to libtool should
> be quoted but aren't, or cases in which we expand a command line with
> eval too many times. Simply quoting `$' may fix this particular
> problem, without fixing the more general problem that should be fixed,
> e.g., other shell meta-characters would remain broken.
>
PR1343 in libjava testsuite always fails since libtool can't handle
/export/build/gnu/gcc/build-i686-linux/i686-pc-linux-gnu/libjava/testsuite/../libtool
--silent --tag=GCJ --mode=compile
/export/build/gnu/gcc/build-i686-linux/gcc/gcj
-B/export/build/gnu/gcc/build-i686-linux/gcc/ --encoding=UTF-8
-B/export/build/gnu/gcc/build-i686-linux/i686-pc-linux-gnu//libjava/ -c -o
PR1343\$2\$x1.o
/export/build/gnu/gcc/build-i686-linux/i686-pc-linux-gnu/libjava/testsuite/PR1343\$2\$x1.class
H.J.