Re: FYI: make libtoolize's pkgvdatadir a private api [libtool--devo--1.0--patch-105]

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Tue, Apr 05, 2005 at 11:08:52AM CEST:
> Ralf Wildenhues wrote:
> 
> > OK to apply this fix?
> 
> In principle I like the patch, but I wonder if we should abstract out
> the setting of _lt_pkgvdatadir so that it is exported to the environment
> for the duration of the whole testsuite?

Good idea.

> If you agree, then I think we should also change the name (again), and
> maybe make it a documented public interface: LIBTOOLIZE_PATH?

Hmm. How about LIBTOOLIZE_DATA or ..DATADIR?  path sounds like "that's
where `libtoolize' will be".  Publishing might be a good idea.

> In the meantime, if you want to apply this to HEAD while we discuss the
> final details, then please go ahead.

We might as well discuss a few more "new testsuite" things while we're at it.

I think you need to check each of the `libtoolize', `autoreconf',
`configure' invocations by themselves for potential failure.  I remember
to have seen spurious PASSes here.

I want to remove all AT_TESTED, as I think that interface is broken.  It
forces me to have `autoreconf' available even if all I want to do is
test template.at on a foreign system.

We'd need an AT_TESTED that does not bail out, and a SKIP mechanism
if tools are not available (AT_XFAIL_IF does this I think).

When the autoconf guys come up with a AT_CHECK like macro which outputs
shell-expanded versions of its argument (I might give it a try myself
eventually), I want to replace most AT_CHECKs with that new macro, so
stresstest output actually helps.

I posted about this some time ago (here and/or on autoconf*).

Re old testsuite: I regularly have spurious tagtrace failures which
should be SKIPs: namely, when the system has different versions of
autotools installed than the ones I built the tarball with.  (I usually
transfer tarballs to test systems to avoid needing autotools there.)

I don't have much time at the moment, but can look more into issues in a
couple of weeks, if you don't beat me there.

Regards,
Ralf


> > Index: tests/testsuite.at
> > ===================================================================
> > RCS file: /cvsroot/libtool/libtool/tests/testsuite.at,v
> > retrieving revision 1.9
> > diff -u -r1.9 testsuite.at
> > --- tests/testsuite.at      4 Apr 2005 17:24:40 -0000       1.9
> > +++ tests/testsuite.at      5 Apr 2005 08:01:14 -0000
> > @@ -43,7 +43,7 @@
> >  m4_define([LT_AT_BOOTSTRAP],
> >  [
> >  test -f ./ltmain.sh || LT_AT_LIBTOOLIZE([--copy])
> > -test -f ./configure || autoreconf --force --verbose --install
> > +test -f ./configure || _lt_pkgvdatadir="$abs_top_srcdir" autoreconf 
> > --force --verbose --install
> >  test -f ./configure || exit 1
> >  ./configure
> >  ])