[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: consolidate Makefile.ams [libtool--gary--1.0--patch-17]
From: |
Ralf Wildenhues |
Subject: |
Re: consolidate Makefile.ams [libtool--gary--1.0--patch-17] |
Date: |
Tue, 12 Apr 2005 19:21:47 +0200 |
User-agent: |
Mutt/1.4.1i |
Hi Gary,
* Gary V. Vaughan wrote on Mon, Apr 11, 2005 at 06:27:24PM CEST:
>
> This changeset came about as a side effect of trying to make
> libltdl/Makefile.am work as a standalone top-level Makefile,
> for correct installation with `libtoolize --ltdl'. And Ralf's mail
> describing why calling make from a make rule is not a good thing,
To be precise: calling make from a make rules is not good if what you
want to do is capture the output. (Maybe I should fold this into an
autoconf.texi patch..)
> The next patch finishes the job, but this one simplifies the interactions
> between bootstrap and the various Makefile.ams, as well as speeding things
> up a little (no submakes required), and making the dependencies between
> files in different directories work implicitly (able to throw away all the
> glue rules).
That's nice.
> Okay to commit to HEAD?
Not exactly like this:
| cd .. && /bin/sh "/tmp/libtool/config"/missing --run automake-1.9a --gnits
| Makefile.am:53: EXTRA_DIST must be set with `=' before using `+='
| Makefile.am:104: EXTRA_DIST multiply defined in condition TRUE ...
| Makefile.am:53: ... `EXTRA_DIST' previously defined here
| make: *** [../Makefile.in] Error 1
Furthermore, fortran tests SKIP now where they used to pass (you missed
one tests/ before fprogram in f77demo-exec.tests).
Other than these nits, seems fine to me.
As reminders:
- make install still misses `libltdl/configure'.
- make uninstall still misses removing libltdl source files.
> Should I port to branch-2-0 for ease of future Makefile.am maintenance?
Yes, but as Bob said, you might want to wait a couple of days before
applying.
> Since the bootstrap process requires that several of the rules for
> files generated in doc and tests already lived in
> $top_srcdir/Makefile.am, along with proxy rules in sub-Makefiles,
> this changeset consolidates almost everything into the top
> Makefile.am, simplifying things considerably:
Funny thing is, the simplification has not turned into a smaller amount
of Makefile.am code -- the number of non-comment lines even grew. :)
Regards,
Ralf