libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] 1.5.14: Incorrect archive member renaming with GNU ar


From: Peter O'Gorman
Subject: Re: [patch] 1.5.14: Incorrect archive member renaming with GNU ar
Date: Sun, 17 Apr 2005 23:28:31 +0900
User-agent: Mozilla Thunderbird 1.0 (Macintosh/20041206)

Ralf Wildenhues wrote:
Hi Peter,

* Peter O'Gorman wrote on Sat, Apr 16, 2005 at 05:30:01PM CEST:

Peter O'Gorman wrote:
|>>
|>> This is Alexandre Oliva's patch with a test case. OK to apply to
|>> branch-1-5
|>> and forward port?
|>
|> Yes.  Please show the forward-port, though.  Nice and clean fix, BTW.

This is the forward port to HEAD. Note that the cross compiling test is
broken, neither $build nor $host are set for the autotest tests.


Then they need to be set
  eval `$LIBTOOL --config | grep host=`
  eval `$LIBTOOL --config | grep build=`
should work.

Hmm.  Maybe we should consider using
  eval `$LIBTOOL --config | grep EGREP=`
  eval `$LIBTOOL --config | $EGREP '(host|build)=`
when lines like these start to accumulate.  (Just thinking out loud.)


Okay to apply?


Nits below.  Other than them (and the fact that I haven't tested),
please apply.

I think I got all these changes in, applied.

Peter
--
Peter O'Gorman - http://www.pogma.com




reply via email to

[Prev in Thread] Current Thread [Next in Thread]